Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ephemeral primitive like in Zookeeper #314

Merged
merged 1 commit into from
Jan 12, 2021
Merged

feat: ephemeral primitive like in Zookeeper #314

merged 1 commit into from
Jan 12, 2021

Conversation

anrs
Copy link
Contributor

@anrs anrs commented Jan 8, 2021

att.

@anrs anrs changed the title feat: ephemeral primitive like in Zookeeper WIP: feat: ephemeral primitive like in Zookeeper Jan 8, 2021
@anrs anrs changed the title WIP: feat: ephemeral primitive like in Zookeeper feat: ephemeral primitive like in Zookeeper Jan 12, 2021
@jschwinger233
Copy link
Member

好像有一个问题, 就拿 Calcium.RegisterService 来说, 这个 PR 改下去后服务不能“死而复生”了..

比如由于网络波动, 某次 store.RegisterService 失败了, 在 HA eru-core 的情况下这个 core 会被自动摘掉; 然后过一小会儿网络又好了, 以前的代码里会立刻复活, 因为 store.RegisterService 会不停发送, 就算某次失败也继续循环, 现在好像不可以了....

@jschwinger233
Copy link
Member

经过沟通后确认没问题, ap

@CMGS CMGS merged commit 0853361 into projecteru2:master Jan 12, 2021
@anrs anrs deleted the ephemeral-node branch February 17, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschwinger233 jschwinger233 jschwinger233 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anrs @jschwinger233 @CMGS