-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule volume resource #161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwinger233
force-pushed
the
zc/device-resource
branch
2 times, most recently
from
December 19, 2019 04:26
613bdbb
to
5f73771
Compare
CMGS
reviewed
Dec 19, 2019
jschwinger233
force-pushed
the
zc/device-resource
branch
from
December 19, 2019 07:11
5f73771
to
47b6272
Compare
jschwinger233
force-pushed
the
zc/device-resource
branch
from
December 19, 2019 07:12
47b6272
to
42261f3
Compare
jschwinger233
force-pushed
the
zc/device-resource
branch
from
December 19, 2019 09:20
89910a4
to
229bf5f
Compare
CMGS
reviewed
Dec 20, 2019
CMGS
reviewed
Dec 20, 2019
CMGS
reviewed
Dec 29, 2019
jschwinger233
force-pushed
the
zc/device-resource
branch
from
January 2, 2020 09:03
47c9f9f
to
03ac088
Compare
CMGS
requested changes
Jan 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外你这个改动导致了大量测试覆盖率下降,得增加对 volume 分配和绑定的单元测试
CMGS
reviewed
Jan 6, 2020
jschwinger233
force-pushed
the
zc/device-resource
branch
from
January 7, 2020 06:46
e2c701c
to
bfb05d3
Compare
CMGS
reviewed
Jan 7, 2020
CMGS
reviewed
Jan 7, 2020
CMGS
reviewed
Jan 8, 2020
jschwinger233
force-pushed
the
zc/device-resource
branch
from
January 8, 2020 10:26
21f0c61
to
720d514
Compare
CMGS
reviewed
Jan 9, 2020
all checks passed lah! |
CMGS
reviewed
Jan 9, 2020
jschwinger233
force-pushed
the
zc/device-resource
branch
from
January 9, 2020 04:25
1938ab6
to
c4fcb5a
Compare
jschwinger233
commented
Jan 9, 2020
jschwinger233
force-pushed
the
zc/device-resource
branch
2 times, most recently
from
January 9, 2020 10:26
0fd59dc
to
6859d19
Compare
jschwinger233
force-pushed
the
zc/device-resource
branch
from
January 9, 2020 10:29
6859d19
to
ca005ab
Compare
CMGS
reviewed
Jan 10, 2020
jschwinger233
commented
Jan 13, 2020
jschwinger233
commented
Jan 13, 2020
CMGS
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.