Added ability for additional, custom fingerprints. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to specify a custom path to a fingerprints.json file which will append new fingerprints to the old, embedded ones.
|
Thanks so much for your contribution @SecGus ! :) We also have a Discord server, which you’re more than welcome to join. It's a great place to connect with fellow contributors and stay updated with the latest developments! |
dogancanbakir
requested changes
Nov 20, 2024
| @@ -13,14 +14,19 @@ type Wappalyze struct { | |||
| } | |||
|
|
|||
| // New creates a new tech detection instance | |||
| func New() (*Wappalyze, error) { | |||
| func New(customFilePaths ...string) (*Wappalyze, error) { | |||
There was a problem hiding this comment.
How about we rename the loadFingerprints as loadDefaultFingerprints and then introduce a new method called something like AddFingerprints etc., to make it cleaner?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, added the ability to specify a custom fingerprints file as an argument (optional). This will append the custom fingerprints to the main, original list of fingerprints.