CRD fqdn regex is too strict #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
suggested changes
Nov 27, 2018
There was a problem hiding this comment.
@PeteE Thanks for fixing this. I'll need you to sign this commit. The easiest way to do this is
git commit -a -s --amend
git push -f
Signed-off-by: Pete Erickson <[email protected]>
|
@PeteE ping, I need you to sign your commit before I can accept this PR. |
|
@PeteE gentle nudge, I cannot merge this until you sign your commit. |
|
@davecheney If I make the same changes and sign the commit, will that be merged? I want his PR to get merged but the gentle nudges don't seem to be working. |
|
@troy0820 sorry, that is not possible. |
|
No problem, I closed the PR. |
|
Thank you. I'm sorry it has to be this way, the lawyers need to see a clean
chain of custardy from any change to the person who wrote it. I know your
intentions were to be helpful but sadly the DCO process does not have a
provision for good intentions.
…On Wed, 19 Dec 2018 at 09:08, Troy Connor ***@***.***> wrote:
No problem, I closed the PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#822 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAcA6S9ddlqMy9zzmN3QbSGRoJyecUmks5u6WdigaJpZM4Y2Zz0>
.
|
|
That's perfectly fine and I definitely understand. I hope to make future contributions to this project. |
davecheney
approved these changes
Jan 7, 2019
|
I’ll take responsibility for merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #821
Allow numbers in TLD.
Example:
my.domain.k8s