Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded maximum TLS version 1.3 #746

Closed
wants to merge 6 commits into from
Closed

Hardcoded maximum TLS version 1.3 #746

wants to merge 6 commits into from

Conversation

cromefire
Copy link
Contributor

Fixes #672

Unverified

No user is associated with the committer email.
Signed-off-by: Cromefire_ <[email protected]>
@davecheney
Copy link
Contributor

This project uses DCO, please sign your commit with -s

Also, you’ll need to fix the failing tests. Thanks.

Unverified

No user is associated with the committer email.
Signed-off-by: Cromefire_ <[email protected]>
@cromefire
Copy link
Contributor Author

This project uses DCO, please sign your commit with -s

Is there any way to fix that after committing?

@davecheney
Copy link
Contributor

davecheney commented Oct 8, 2018 via email

@cromefire
Copy link
Contributor Author

Actually it is signed:
image
image

Is it a problem that I use my Username not my id?

Cromefire_ added 4 commits October 8, 2018 16:46

Unverified

No user is associated with the committer email.
Signed-off-by: cromefire <[email protected]>

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.
Signed-off-by: cromefire <[email protected]>

Unverified

No user is associated with the committer email.
Signed-off-by: cromefire <[email protected]>
@cromefire
Copy link
Contributor Author

cromefire commented Oct 8, 2018

I think I've broken it completely

@cromefire
Copy link
Contributor Author

Should I just redo this?

@davecheney
Copy link
Contributor

davecheney commented Oct 8, 2018 via email

@cromefire
Copy link
Contributor Author

https://github.com/heptio/contour/blob/master/CONTRIBUTING.md#dco-sign-off

I thing he didn't like that I used Cromefire_ instead of cromefire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants