-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded maximum TLS version 1.3 #746
Conversation
Signed-off-by: Cromefire_ <[email protected]>
This project uses DCO, please sign your commit with -s Also, you’ll need to fix the failing tests. Thanks. |
Signed-off-by: Cromefire_ <[email protected]>
Is there any way to fix that after committing? |
git commit -s --amend
… On 9 Oct 2018, at 01:40, Cromefire_ ***@***.***> wrote:
This project uses DCO, please sign your commit with -s
Is there any way to fix that after committing?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Signed-off-by: cromefire <[email protected]>
Signed-off-by: cromefire <[email protected]>
Signed-off-by: cromefire <[email protected]>
I think I've broken it completely |
Should I just redo this? |
If that’s easier, sure.
https://github.com/heptio/contour/blob/master/CONTRIBUTING.md#dco-sign-off
… On 9 Oct 2018, at 02:08, Cromefire_ ***@***.***> wrote:
Should I just redo this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I thing he didn't like that I used |
Fixes #672