Remove workaround for gen-crd-api-reference-docs #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tero Saarni <[email protected]>
tsaarni
requested review from
skriss and
sunjayBhatia
and removed request for
a team
tsaarni
added
the
release-note/none-required
sunjayBhatia
requested review from
a team,
davinci26 and
izturn
and removed request for
a team
|
This PR is continuation for #6874. BTW you may already be aware that Go 1.24 will introduce a new way to run tools https://tip.golang.org/doc/go1.24#tools |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6885 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 134 134
Lines 20087 20087
=======================================
Hits 16286 16286
Misses 3507 3507
Partials 294 294 |
Oh cool, hadn't seen that but we should definitely make use of it once it's available! Thanks for the reference |
skriss
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the workaround for the typealias issue, which was needed for recent Go compiler versions. Since no new releases have been made since v0.3.0 in 2021, the latest commit hash is used instead.
Additionally, the tool was previously installed in the user's
GOBINdirectory. Nowgo runis used to avoid requiring installing without user's consent.