Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shutdown manager: use filter on downstream_cx_active stats url #6523

Merged
merged 6 commits into from
Jun 20, 2024
Merged

shutdown manager: use filter on downstream_cx_active stats url #6523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0bcac42
use filter on downstream_cx_active stats url
therealak12 Jun 20, 2024
083b4c4
add release note
therealak12 Jun 20, 2024
9aa32e1
improve release note
therealak12 Jun 20, 2024
b2ed096
add comment for prometheusURL
therealak12 Jun 20, 2024
394af7a
use more stricter regex
therealak12 Jun 20, 2024
f0a7e54
improve changelog message
therealak12 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/6523-therealak12-small.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve shutdown manager query to the Envoy stats endpoint for active connections by utilizing a regex filter query param.
4 changes: 3 additions & 1 deletion cmd/contour/shutdownmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ import (
)

const (
prometheusURL = "http://unix/stats/prometheus"
// The prometheusURL is used to fetch the envoy metrics. Note that the filter
// value matches Envoy's raw stat names (i.e. those on the `/stats/` endpoint).
prometheusURL = "http://unix/stats/prometheus?filter=^http\\..*\\.downstream_cx_active$"
healthcheckFailURL = "http://unix/healthcheck/fail"
prometheusStat = "envoy_http_downstream_cx_active"
)
Expand Down