change default xDS server to envoy #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6146 +/- ##
==========================================
+ Coverage 81.19% 81.20% +0.01%
==========================================
Files 133 133
Lines 15803 15803
==========================================
+ Hits 12831 12833 +2
+ Misses 2678 2677 -1
+ Partials 294 293 -1
|
skriss
force-pushed
the
pr-envoy-xds-server
branch
from
ffffc2e to
d6b8905
Compare
skriss
added
release-note/major
skriss
force-pushed
the
pr-envoy-xds-server
branch
from
d6b8905 to
421c078
Compare
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
skriss
removed
the
lifecycle/stale
skriss
force-pushed
the
pr-envoy-xds-server
branch
from
421c078 to
f2417c1
Compare
The default xDS server implementation is now `envoy`, i.e. the go-control-plane implementation. Updates projectcontour#2134. Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
pr-envoy-xds-server
branch
from
f2417c1 to
e086a3f
Compare
skriss
changed the title
Signed-off-by: Steve Kriss <[email protected]>
|
One note, feature tests have not yet been updated to use the envoy xds server (ref. #6254). If folks feel like that should be a prerequisite for changing the default, I'll work on getting that done. I've done a quick test of it and looks like there will be a number of test changes required. Update: featuretests updated in #6255 |
skriss
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
izturn and
clayton-gonsalves
and removed request for
a team
Signed-off-by: Steve Kriss <[email protected]>
|
@sunjayBhatia thanks for the review on #6255; once this one is approved as well I'll merge 'em both. |
sunjayBhatia
approved these changes
Mar 12, 2024
lubronzhan
pushed a commit
to lubronzhan/contour
that referenced
this pull request
Mar 13, 2024
The default xDS server implementation is now `envoy`, i.e. the go-control-plane implementation. Updates projectcontour#2134. Signed-off-by: Steve Kriss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default xDS server implementation is
now
envoy, i.e. the go-control-planeimplementation.
Updates #2134.
Signed-off-by: Steve Kriss [email protected]