internal/xds/v3: Improve logging on connection close #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sunjayBhatia
commented
Jan 20, 2023
sunjayBhatia
commented
- contour xDS server does not log errors if connection was canceled by client, detected via gRPC code
- when connection is closed change to debug from info level to avoid log noise
- add stream open/close logging callbacks for go-control-plane implementation
- contour xDS server does not log errors if connection was canceled by client, detected via gRPC code - when connection is closed change to debug from info level to avoid log noise - add stream open/close logging callbacks for go-control-plane implementation Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
added
the
release-note/small
sunjayBhatia
requested review from
stevesloka and
skriss
and removed request for
a team
Signed-off-by: Sunjay Bhatia <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4993 +/- ##
==========================================
+ Coverage 77.56% 77.60% +0.04%
==========================================
Files 139 139
Lines 16801 16818 +17
==========================================
+ Hits 13032 13052 +20
+ Misses 3514 3512 -2
+ Partials 255 254 -1
|
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
…4993) - contour xDS server does not log errors if connection was canceled by client, detected via gRPC code - when connection is closed change to debug from info level to avoid log noise - add stream open/close logging callbacks for go-control-plane implementation Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
…4993) - contour xDS server does not log errors if connection was canceled by client, detected via gRPC code - when connection is closed change to debug from info level to avoid log noise - add stream open/close logging callbacks for go-control-plane implementation Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
…4993) - contour xDS server does not log errors if connection was canceled by client, detected via gRPC code - when connection is closed change to debug from info level to avoid log noise - add stream open/close logging callbacks for go-control-plane implementation Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.