IngressRoute CRD Validation #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
force-pushed
the
crdValidation
branch
from
4ae63dc to
81f4e1e
Compare
alexbrand
reviewed
Jun 20, 2018
deployment/common/common.yaml
Outdated
| properties: | ||
| fqdn: | ||
| type: string | ||
| pattern: ^([a-z0-9]+(-[a-z0-9]+)*\.)+[a-z]{2,}$ |
There was a problem hiding this comment.
Are uppercase chars not allowed in FQDNs?
There was a problem hiding this comment.
Yup they are allowed, just was going with the default that they are typically lowercase. Will update to follow the spec.
deployment/common/common.yaml
Outdated
| type: string | ||
| pattern: ^\/.*$ | ||
| delegate: | ||
| type: string |
There was a problem hiding this comment.
Should this be type: object?
deployment/common/common.yaml
Outdated
| required: | ||
| - name | ||
| - namespace | ||
| pattern: ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$ # DNS-1123 |
There was a problem hiding this comment.
extra/left-over pattern?
There was a problem hiding this comment.
yes, similar to previous, will remove
|
@alexbrand @stevesloka you two know the most about defining validations. Please merge this when you are happy. Thanks Dave |
Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: Steve Sloka <[email protected]>
stevesloka
force-pushed
the
crdValidation
branch
from
c154337 to
ac07c5a
Compare
|
@alexbrand PR comments should all be resolved now |
Signed-off-by: Steve Sloka <[email protected]>
|
@stevesloka can you please rerun |
sunjayBhatia
added a commit
that referenced
this pull request
Jan 30, 2023
Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CRD Validation to the IngressRoute spec. One thing to note is it defines an Enum of values allowed for the
strategyfield which is not yet implemented. We may need to return to this validation once that feature lands.// Fixes #416
Signed-off-by: Steve Sloka [email protected]