cmd/contour: Enable retry for shutdown-manager initiating Envoy healthcheck fail #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hcheck fail The call in the shutdown-manager to intitiate the Envoy healthcheck fail HTTP request did not retry in the event that the call fails. Adds the client-go retry.OnError method which takes a backoff object allowing for a retry with backoff in the event the request fails. Fixes projectcontour#2262 Signed-off-by: Steve Sloka <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3136 +/- ##
==========================================
- Coverage 74.14% 74.03% -0.11%
==========================================
Files 96 96
Lines 5990 6001 +11
==========================================
+ Hits 4441 4443 +2
- Misses 1453 1463 +10
+ Partials 96 95 -1
|
|
needs rebase + CI to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call in the shutdown-manager to intitiate the Envoy healthcheck fail HTTP request
did not retry in the event that the call fails. Adds the client-go retry.OnError method
which takes a backoff object allowing for a retry with backoff in the event the request
fails.
Fixes #2262
Signed-off-by: Steve Sloka [email protected]