Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a nlb doc typo #2839

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Fix a nlb doc typo #2839

merged 1 commit into from
Aug 27, 2020

Conversation

tong101
Copy link
Contributor

@tong101 tong101 commented Aug 27, 2020

On deploy-aws-nlb guide, it refers to a wrong service envoy file.
Fix the file name to point to correct file.

Change-Id: Ia2186796c9babb84d199c72bbbdc3da2fd9262ae
Signed-off-by: Tong Liu [email protected]

On deploy-aws-nlb guide, it refers to a wrong service envoy file.
Fix the file name to point to correct file.

Change-Id: Ia2186796c9babb84d199c72bbbdc3da2fd9262ae
Signed-off-by: Tong Liu <[email protected]>
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #2839 into main will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2839      +/-   ##
==========================================
+ Coverage   76.44%   76.48%   +0.03%     
==========================================
  Files          73       73              
  Lines        5711     5712       +1     
==========================================
+ Hits         4366     4369       +3     
+ Misses       1259     1258       -1     
+ Partials       86       85       -1     
Impacted Files Coverage Δ
internal/dag/cache.go 97.64% <0.00%> (+0.79%) ⬆️

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tong101!

@skriss skriss merged commit d902464 into projectcontour:main Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants