cmd/contour: add drain-delay arg to the envoy shutdown command #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2820 +/- ##
==========================================
- Coverage 76.52% 76.39% -0.14%
==========================================
Files 73 73
Lines 5691 5706 +15
==========================================
+ Hits 4355 4359 +4
- Misses 1248 1260 +12
+ Partials 88 87 -1
|
|
The codecov is showing changes unrelated to this PR. |
skriss
requested changes
Aug 24, 2020
There was a problem hiding this comment.
Thanks for the PR @laurovenancio! This seems like a fine change to me but we'll see what the other maintainers think. One small nit.
Fixes #2819 Depends on #2817 Signed-off-by: Lauro Ramos Venancio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2819
Depends on #2817
Signed-off-by: Lauro Ramos Venancio [email protected]