Fix Envoy service status watching #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2605 +/- ##
==========================================
- Coverage 76.88% 76.79% -0.10%
==========================================
Files 71 71
Lines 5498 5502 +4
==========================================
- Hits 4227 4225 -2
- Misses 1185 1190 +5
- Partials 86 87 +1
|
youngnick
force-pushed
the
fix-service-watching
branch
from
c38d8e1 to
8ae50f2
Compare
We all missed in projectcontour#2583 that not all informers handle Unstructured objects; wrap the service status informer in the dynamicHandler to ensure that no Unstructured objects make it through. Service status watching was broken before this, as it didn't handle Unstructured. Signed-off-by: Nick Young <[email protected]>
youngnick
force-pushed
the
fix-service-watching
branch
from
8ae50f2 to
3db40fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We all missed in #2583 that not all informers handle Unstructured objects; wrap the service status informer in the dynamicHandler to ensure that no Unstructured objects make it through.
Service status watching was broken before this, as it didn't handle Unstructured.
Signed-off-by: Nick Young [email protected]