Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: add versioned quickstart redirects #2552

Merged
merged 1 commit into from
May 27, 2020
Merged

site: add versioned quickstart redirects #2552

merged 1 commit into from
May 27, 2020

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented May 27, 2020

Add netlify redirects to the versioned quickstart YAML. This improves
the deployment experience for operators pinning to Contour versions,
and for testers verifying upgrades.

Signed-off-by: James Peach [email protected]

@jpeach jpeach marked this pull request as ready for review May 27, 2020 00:46
@jpeach jpeach requested a review from SDBrett May 27, 2020 00:46
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #2552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2552   +/-   ##
=======================================
  Coverage   77.66%   77.66%           
=======================================
  Files          71       71           
  Lines        5920     5920           
=======================================
  Hits         4598     4598           
  Misses       1217     1217           
  Partials      105      105

@jpeach jpeach requested review from stevesloka and youngnick May 27, 2020 00:46
@jpeach
Copy link
Contributor Author

jpeach commented May 27, 2020

Verified that this works as expected:

$ curl https://deploy-preview-2552--projectcontour.netlify.app/quickstart/v1.2.1/contour.yaml
Redirecting to https://raw.githubusercontent.com/projectcontour/contour/v1.2.1/examples/render/contour.yaml

$ curl https://deploy-preview-2552--projectcontour.netlify.app/quickstart/v1.4.0/contour.yaml
Redirecting to https://raw.githubusercontent.com/projectcontour/contour/v1.4.0/examples/render/contour.yaml

youngnick
youngnick approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small question.

netlify.toml Show resolved Hide resolved
@jpeach
site: add versioned quickstart redirects
c49694f 
Add netlify redirects to the versioned quickstart YAML. This improves
the deployment experience for operators pinning to Contour versions,
and for testers verifying upgrades.

Signed-off-by: James Peach <[email protected]>
@jpeach jpeach force-pushed the redirect-versioned-quickstart branch from 380e3ec to c49694f Compare May 27, 2020 01:06
@jpeach jpeach merged commit 477c154 into projectcontour:master May 27, 2020
@jpeach jpeach deleted the redirect-versioned-quickstart branch May 27, 2020 01:23
@jpeach jpeach added this to the 1.5.0 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngnick youngnick youngnick approved these changes

@SDBrett SDBrett Awaiting requested review from SDBrett

@stevesloka stevesloka Awaiting requested review from stevesloka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpeach @youngnick