-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add fallback certificate docs #2535
docs: add fallback certificate docs #2535
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2535 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 72 72
Lines 5892 5892
=======================================
Hits 4528 4528
Misses 1264 1264
Partials 100 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just needs a bit of proofing.
5ae0c97
to
e352cbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just tidy up the grammar nits :)
I just double-checked and we don't backquote "HTTPProxy" in this doc, so can you please remove those from the mentions here? Thanks!
e352cbd
to
97b5400
Compare
Signed-off-by: Steve Sloka <[email protected]>
97b5400
to
2feccc8
Compare
Updates #1503 by adding fallback certificate documentation.
Signed-off-by: Steve Sloka [email protected]