Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add fallback certificate docs #2535

Merged

Conversation

stevesloka
Copy link
Member

Updates #1503 by adding fallback certificate documentation.

Signed-off-by: Steve Sloka [email protected]

@stevesloka stevesloka added this to the 1.5.0 milestone May 18, 2020
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #2535 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2535   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files          72       72           
  Lines        5892     5892           
=======================================
  Hits         4528     4528           
  Misses       1264     1264           
  Partials      100      100           

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just needs a bit of proofing.

site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
site/docs/master/httpproxy.md Show resolved Hide resolved
site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
@stevesloka stevesloka force-pushed the fallbackCertificateDocs branch from 5ae0c97 to e352cbd Compare May 19, 2020 19:00
@stevesloka stevesloka requested a review from jpeach May 19, 2020 19:00
site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
site/docs/master/httpproxy.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just tidy up the grammar nits :)

I just double-checked and we don't backquote "HTTPProxy" in this doc, so can you please remove those from the mentions here? Thanks!

@stevesloka stevesloka force-pushed the fallbackCertificateDocs branch from e352cbd to 97b5400 Compare May 21, 2020 20:38
@stevesloka stevesloka force-pushed the fallbackCertificateDocs branch from 97b5400 to 2feccc8 Compare May 22, 2020 17:05
@stevesloka stevesloka merged commit 9cb8aa9 into projectcontour:master May 22, 2020
@stevesloka stevesloka deleted the fallbackCertificateDocs branch May 22, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants