Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add gosec to the linter checks #2526

Merged
merged 1 commit into from
May 15, 2020

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented May 15, 2020

All the issues currently flagged by gosec are false positives,
but there's no real harm in adding it to the lint checks.

This fixes #2525.

Signed-off-by: James Peach [email protected]

All the issues currently flagged by gosec are false positives,
but there's no real harm in adding it to the lint checks.

This fixes projectcontour#2525.

Signed-off-by: James Peach <[email protected]>
@jpeach jpeach requested review from stevesloka and youngnick May 15, 2020 03:34
Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #2526 into master will increase coverage by 0.03%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2526      +/-   ##
==========================================
+ Coverage   76.57%   76.60%   +0.03%     
==========================================
  Files          68       68              
  Lines        5515     5515              
==========================================
+ Hits         4223     4225       +2     
+ Misses       1194     1193       -1     
+ Partials       98       97       -1     
Impacted Files Coverage Δ
cmd/contour/shutdownmanager.go 25.00% <0.00%> (ø)
internal/certgen/makecerts.go 82.71% <100.00%> (ø)
internal/envoy/cluster.go 100.00% <100.00%> (ø)
internal/envoy/secret.go 100.00% <100.00%> (ø)
internal/dag/cache.go 95.98% <0.00%> (+0.72%) ⬆️

@jpeach jpeach merged commit cc7088f into projectcontour:master May 15, 2020
@jpeach jpeach deleted the add-golint-gosec branch May 15, 2020 03:42
@jpeach jpeach added this to the 1.5.0 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gosec linter to CI
2 participants