Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fallbackCertificate design #2504

Merged
merged 1 commit into from
May 7, 2020

Conversation

stevesloka
Copy link
Member

Updates some additional concepts around how the fallbackCertificate is going to be enabled. The key changes are:

  1. The fallbackSecret must be delegated via TLSCertificateDelegation
  2. The minimum-protocol-version will be used from the Contour configuration file
  3. Client Validation is not compatible with Fallback Certificate

Signed-off-by: Steve Sloka [email protected]

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #2504 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2504   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files          68       68           
  Lines        5513     5513           
=======================================
  Hits         4224     4224           
  Misses       1192     1192           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff18e9...13756b5. Read the comment docs.

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@stevesloka stevesloka merged commit 2672fac into projectcontour:master May 7, 2020
@stevesloka stevesloka deleted the updateFallbackDesign branch May 7, 2020 03:01
@jpeach jpeach added this to the 1.5.0 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants