Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kube support matrix #2471

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Update Kube support matrix #2471

merged 1 commit into from
Apr 27, 2020

Conversation

youngnick
Copy link
Member

Signed-off-by: Nick Young [email protected]

@youngnick youngnick self-assigned this Apr 27, 2020
@jpeach
Copy link
Contributor

jpeach commented Apr 27, 2020

Are these changes related? What's the problem with the zoom link?

@youngnick
Copy link
Member Author

We shouldn't have public Zoom links because of the risk of Zoom bombing. Was just trying to combine two small PRs - they are not otherwise related.

@codecov
Copy link

codecov bot commented Apr 27, 2020 •
edited
Loading

Codecov Report

Merging #2471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2471   +/-   ##
=======================================
  Coverage   76.76%   76.76%           
=======================================
  Files          68       68           
  Lines        5522     5522           
=======================================
  Hits         4239     4239           
  Misses       1187     1187           
  Partials       96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb6d9c...c299940. Read the comment docs.

@youngnick
Copy link
Member Author

Just the Kube changes.

@youngnick youngnick changed the title Update Kube support matrix and remove Zoom link from community page Update Kube support matrix Apr 27, 2020
jpeach
jpeach suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits. I probably would have ordered the Kubernetes versions from low to high, but either is fine.

site/_resources/kubernetes.md Outdated Show resolved Hide resolved
site/_resources/kubernetes.md Outdated Show resolved Hide resolved
site/_resources/kubernetes.md Outdated Show resolved Hide resolved
@youngnick youngnick requested a review from jpeach April 27, 2020 01:30
@youngnick
Copy link
Member Author

I added master as an option, I think I'll do this for the Envoy one as well if everyone approves.

Update Kube support matrix
c299940 
Signed-off-by: Nick Young <[email protected]>
jpeach
jpeach approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

site/_resources/kubernetes.md Outdated Show resolved Hide resolved
@jpeach jpeach merged commit b40d846 into projectcontour:master Apr 27, 2020
@jpeach jpeach added this to the 1.5.0 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach approved these changes

@stevesloka stevesloka Awaiting requested review from stevesloka

@jonasrosland jonasrosland Awaiting requested review from jonasrosland

@SDBrett SDBrett Awaiting requested review from SDBrett

Assignees

@youngnick youngnick

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@youngnick @jpeach