Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation of certgen Job image tag usage #2424

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

youngnick
Copy link
Member

Updates #2423
Updates #2395
Updates #2150
Updates #2030

Signed-off-by: Nick Young [email protected]

@youngnick youngnick added this to the 1.4.0 milestone Apr 8, 2020
@youngnick youngnick requested review from jpeach and stevesloka April 8, 2020 23:23
@youngnick youngnick self-assigned this Apr 8, 2020
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@youngnick youngnick force-pushed the certgen-image-tag branch from 319e7d3 to 4c4306c Compare April 9, 2020 00:02
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #2424 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2424      +/-   ##
==========================================
+ Coverage   76.98%   77.02%   +0.03%     
==========================================
  Files          66       66              
  Lines        5475     5475              
==========================================
+ Hits         4215     4217       +2     
+ Misses       1164     1163       -1     
+ Partials       96       95       -1     
Impacted Files Coverage Δ
internal/dag/cache.go 95.98% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2099d1c...34c1a0f. Read the comment docs.

@youngnick youngnick force-pushed the certgen-image-tag branch 2 times, most recently from c47ffb3 to 89ac2b8 Compare April 9, 2020 01:12
@youngnick youngnick force-pushed the certgen-image-tag branch from 89ac2b8 to 34c1a0f Compare April 9, 2020 01:14
@youngnick youngnick merged commit 6c444d4 into projectcontour:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants