Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/assert: Add docs to assert.Equal #2417

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

youngnick
Copy link
Member

Fixes #1123.

Signed-off-by: Nick Young [email protected]

@youngnick youngnick requested review from jpeach and stevesloka April 7, 2020 04:28
@youngnick youngnick self-assigned this Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #2417 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2417   +/-   ##
=======================================
  Coverage   77.16%   77.16%           
=======================================
  Files          66       66           
  Lines        5448     5448           
=======================================
  Hits         4204     4204           
  Misses       1154     1154           
  Partials       90       90           
Impacted Files Coverage Δ
internal/assert/assert.go 72.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b24e04...5ac9534. Read the comment docs.

@youngnick youngnick merged commit 0917345 into projectcontour:master Apr 7, 2020
@jpeach jpeach added this to the 1.5.0 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve output of failing tests comparing structs
2 participants