Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the PR template with new links and frontmatter #2382

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix the PR template with new links and frontmatter #2382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
---
name: Pull request
about: Tell us about your contribution
---

<!-- Thanks for contributing to Contour!

Before submitting a pull request, make sure you read about our Contribution Workflow here: https://github.com/heptio/contour/blob/master/CONTRIBUTING.md#contribution-workflow
Before submitting a pull request, make sure you read about our Contribution Workflow here: https://github.com/projectcontour/contour/blob/master/CONTRIBUTING.md#contribution-workflow

Some notable call outs from our Contribution Workflow:

1. All PR's should have a `Fixes #NNN` or `Updates #NNN` line in the pull request description. Contour operates according to the talk, then code rule. If you plan to submit a pull request for anything more than a typo or obvious bug fix, first you should raise an issue to discuss your proposal, before submitting any code.
2. All commits to Contour must have a Developer Certificate of Origin (DCO) sign off. More about that here https://github.com/heptio/contour/blob/master/CONTRIBUTING.md#dco-sign-off
2. All commits to Contour must have a Developer Certificate of Origin (DCO) sign off. More about that here https://github.com/projectcontour/contour/blob/master/CONTRIBUTING.md#dco-sign-off

-->