Move CRD informer list generation to k8s #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngnick
force-pushed
the
informermap
branch
3 times, most recently
from
b85f304 to
b9aa0a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2352 +/- ##
==========================================
- Coverage 78.15% 77.97% -0.18%
==========================================
Files 60 61 +1
Lines 5227 5236 +9
==========================================
- Hits 4085 4083 -2
- Misses 1056 1066 +10
- Partials 86 87 +1
Continue to review full report at Codecov.
|
jpeach
reviewed
Mar 18, 2020
davecheney
reviewed
Mar 18, 2020
davecheney
reviewed
Mar 19, 2020
youngnick
force-pushed
the
informermap
branch
2 times, most recently
from
028d181 to
1496df4
Compare
jpeach
suggested changes
Mar 22, 2020
There was a problem hiding this comment.
Make a few suggestions; I think we can use this to replace more of the informer set up.
I'd like to also replace the namespacedInformerFactories initialization, but that's probably a bigger scope than you want to tackle here. Do you mind filing an issue to address that?
This is in preparation for adding in filtering by discovered CRD types. Updates projectcontour#2219 Signed-off-by: Nick Young <[email protected]>
jpeach
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for adding in filtering by discovered CRD types.
Updates #2219
Signed-off-by: Nick Young [email protected]