cmd/contour: simplify leadership election setup #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates projectcontour#403 Ingress status updates depend on leadership election. This PR moves leadership setup outside doServe and simplifies the interaction with EventHandler.IsLeader. Signed-off-by: Dave Cheney <[email protected]>
|
@jpeach I looked at moving this logic to |
Codecov Report
@@ Coverage Diff @@
## master #2348 +/- ##
==========================================
+ Coverage 77.96% 77.97% +0.01%
==========================================
Files 60 60
Lines 5205 5204 -1
==========================================
Hits 4058 4058
+ Misses 1059 1058 -1
Partials 88 88
Continue to review full report at Codecov.
|
jpeach
reviewed
Mar 17, 2020
| // a channel which will become ready when this process becomes the leader, or, in the | ||
| // event that leadership election is disabled, the channel will be ready immediately. | ||
| func setupLeadershipElection(g *workgroup.Group, log logrus.FieldLogger, ctx *serveContext, clients *k8s.Clients, updateNow func()) chan struct{} { | ||
| if ctx.DisableLeaderElection { |
There was a problem hiding this comment.
Suggest you pull this into a separate function becomeElectedLeader(), then check ctx.DisableLeaderElection from the caller.
jpeach
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #403
Ingress status updates depend on leadership election. This PR moves
leadership setup outside doServe and simplifies the interaction with
EventHandler.IsLeader.
Signed-off-by: Dave Cheney [email protected]