cmd/contour: unify client creation #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
reviewed
Mar 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #2339 +/- ##
==========================================
- Coverage 77.91% 77.79% -0.12%
==========================================
Files 59 60 +1
Lines 5208 5216 +8
==========================================
Hits 4058 4058
- Misses 1062 1070 +8
Partials 88 88
Continue to review full report at Codecov.
|
Updates projectcontour#403 Before I can add ingress status support to cmd/contour I need to clean up the serve method. This change unifies the creation of the various clients to a single method and improves the naming of the various return values -- they are infomer _factories_ not informers. Signed-off-by: Dave Cheney <[email protected]>
Signed-off-by: Dave Cheney <[email protected]>
davecheney
commented
Mar 16, 2020
| } | ||
|
|
||
| // ClientSet returns the Kubernetes Core v1 ClientSet. | ||
| func (c *Clients) ClientSet() *kubernetes.Clientset { |
There was a problem hiding this comment.
These getters are unpleasant, I'll try to clean them up in a future PR.
There was a problem hiding this comment.
Yeh, I'd be inclined to just make the struct members public, but this is fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #403
Before I can add ingress status support to cmd/contour I need to clean
up the serve method. This change unifies the creation of the various
clients to a single method and improves the naming of the various return
values -- they are infomer factories not informers.
Signed-off-by: Dave Cheney [email protected]