Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/dag: reject HTTPProxy's that lack at least one service per route #2332

Merged
merged 1 commit into from
Mar 11, 2020
Merged

internal/dag: reject HTTPProxy's that lack at least one service per route #2332

merged 1 commit into from
Mar 11, 2020

Conversation

davecheney
Copy link
Contributor

@davecheney davecheney commented Mar 11, 2020 •
edited
Loading

Fixes #2309

Reject any HTTPProxy that does not have at least one service entry per
route. This logic is enforced in the 1.3.0 CRD validations.

This PR does not include support for IngressRoute.

Signed-off-by: Dave Cheney [email protected]

@davecheney
internal/dag: reject HTTPProxy's that lack at least one service per r…
ca07fe1 
…oute

Fixes projectcontour#2309

Reject any HTTPProxy that does not have at least one service entry per
route. This logic is enforced in the 1.3.0 CRD validations.

This PR does not include support for IngressRoute.

Signed-off-by: Dave Cheney <[email protected]>
@davecheney davecheney added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 11, 2020
@davecheney davecheney added this to the 1.3.0 milestone Mar 11, 2020
@davecheney davecheney requested review from jpeach and youngnick March 11, 2020 04:49
@davecheney davecheney changed the title internal/dag: reject HTTPProxy's that lack at least one service per r… internal/dag: reject HTTPProxy's that lack at least one service per route Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #2332 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
+ Coverage   77.90%   77.91%   +0.01%     
==========================================
  Files          59       59              
  Lines        5205     5208       +3     
==========================================
+ Hits         4055     4058       +3     
  Misses       1062     1062              
  Partials       88       88
Impacted Files Coverage Δ
internal/dag/builder.go 92.69% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87ba77...ca07fe1. Read the comment docs.

@davecheney davecheney merged commit dec1b64 into projectcontour:master Mar 11, 2020
@davecheney davecheney deleted the fixedbugs/2309 branch March 11, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach approved these changes

@youngnick youngnick Awaiting requested review from youngnick

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

internal/{dag, contour}: ensure that a route has at least one service
2 participants
@davecheney @jpeach