Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: Add docs on how to rotate gRPC certs #2282

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

stevesloka
Copy link
Member

Fixes #1857 by documenting how to rotate certs between Envoy<>Contour.

Signed-off-by: Steve Sloka [email protected]

@stevesloka stevesloka added this to the 1.3.0 milestone Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2282 into master will increase coverage by 0.09%.
The diff coverage is 68.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
+ Coverage   77.35%   77.45%   +0.09%     
==========================================
  Files          58       59       +1     
  Lines        5154     5234      +80     
==========================================
+ Hits         3987     4054      +67     
- Misses       1080     1092      +12     
- Partials       87       88       +1
Impacted Files Coverage Δ
internal/k8s/syncer.go 0% <0%> (ø)
cmd/contour/serve.go 0% <0%> (ø) ⬆️
cmd/contour/contour.go 3.84% <0%> (-0.11%) ⬇️
internal/dag/cache.go 88.59% <100%> (+2.32%) ⬆️
internal/contour/handler.go 74.52% <100%> (-0.93%) ⬇️
cmd/contour/servecontext.go 94.54% <100%> (+0.05%) ⬆️
internal/k8s/converter.go 55.95% <90%> (+8.98%) ⬆️
internal/k8s/kind.go 100% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bf008...4ccdafe. Read the comment docs.

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevesloka stevesloka merged commit 92f6a90 into projectcontour:master Feb 25, 2020
@stevesloka stevesloka deleted the rotateCertsDocs branch February 25, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Document how to rotate certs for gRPC connection
2 participants