Ensure certgen handles already-existing secrets correctly #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
approved these changes
Jan 30, 2020
| @@ -103,6 +104,10 @@ func writeCACertKube(client *kubernetes.Clientset, namespace string, cert []byte | |||
| secret := newCertOnlySecret("cacert", namespace, "cacert.pem", cert) | |||
| _, err := client.CoreV1().Secrets(namespace).Create(secret) | |||
| if err != nil { | |||
| if k8serrors.IsAlreadyExists(err) { | |||
There was a problem hiding this comment.
Nit: would this style be more canonical?
if _, err := client.CoreV1().Secrets(namespace).Create(secret); if err != nil {
...
}There was a problem hiding this comment.
Won't hurt. I'll change it.
|
@youngnick Is there a place to document this? |
|
It's what we always said the behaviour was, and the inspiration behind having certgen being a Job in the first place. I've obviously missed a big test case when doing this originally, 🤦♂. I guess my answer is, "I'm not sure". |
youngnick
force-pushed
the
issues/2150
branch
from
9ef3cec to
cf06214
Compare
|
On 30 Jan 2020, at 2:02 pm, Nick Young ***@***.***> wrote:
I guess my answer is, "I'm not sure".
Then should we file an issue to document certgen?
|
|
#2183 created. I'll merge this now and work on that. |
Fixes projectcontour#2150 Signed-off-by: Nick Young <[email protected]>
youngnick
force-pushed
the
issues/2150
branch
from
cf06214 to
679d061
Compare
|
Does certgen recreates existing certificates if expired? |
|
On Jan 31, 2020, at 4:28 PM, Ryan Elian ***@***.***> wrote:
Does certgen recreates existing certificates if expired?
No. To regenerate the certificates you would need to delete the secrets first.
|
stevesloka
added
the
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2150 by ensuring that the
contour certgenJob will succeed if the secrets already exist.Signed-off-by: Nick Young [email protected]