internal/dag: mark ingress.class annotation valid for HTTPProxies #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "kubernetes.io/ingress.class" annotation is valid for all ingress-like document kinds. This fixes projectcontour#2119. Signed-off-by: James Peach <[email protected]>
jpeach
changed the title
jpeach
force-pushed
the
no-ingress-class-warning
branch
from
9d5883c to
461cecb
Compare
davecheney
approved these changes
Jan 16, 2020
|
Should the ingress class go in the HTTPProxy document and not an annotation? |
|
On 17 Jan 2020, at 8:54 am, Steve Sloka ***@***.***> wrote:
Should the ingress class go in the HTTPProxy document and not an annotation?
Possibly, as a separate change, though we can't remove the annotation support now without breaking compatibility.
|
I don't have a strong opinion about this but I wanted to give some historical detail. When we were adding ingressroute we asked the same question and at the time decided that ingress class was probably an appropriate use of an annotation, it is more or less a special kind of label. We might have also talked about adding the equivalent of the annotation as a field, but at the time that didn't go anywhere. |
|
// #720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "kubernetes.io/ingress.class" annotation is valid for all
ingress-like document kinds.
This fixes #2119.
Signed-off-by: James Peach [email protected]