Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Add 'ttlSecondsFinished' to the certgen job and set the image to latest #2084

Merged
merged 1 commit into from
Jan 7, 2020
Merged

examples: Add 'ttlSecondsFinished' to the certgen job and set the image to latest #2084

merged 1 commit into from
Jan 7, 2020

Conversation

stevesloka
Copy link
Member

Fixes #2030 by implementing the following:

  • Update the certgen job to use docker tag latest
  • Add ttlSecondsAfterFinished: 0 which if running a cluster v1.12+ and enabled feature gate will delete the cert-gen job after the job is complete

Signed-off-by: Steve Sloka [email protected]

@stevesloka stevesloka added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 7, 2020
@stevesloka stevesloka added this to the 1.1.0 milestone Jan 7, 2020
jpeach
jpeach approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevesloka stevesloka merged commit 5c6fc0e into projectcontour:master Jan 7, 2020
@stevesloka stevesloka deleted the quickstartJob branch January 7, 2020 21:19
@youngnick youngnick mentioned this pull request Jan 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Cannot reapply Quickstart yaml if the contour version has changed in the job spec
2 participants
@stevesloka @jpeach