internal/dag: reject certificates with CN or SubjectAltName #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
force-pushed
the
fixedbugs/1965
branch
from
14ed4c5 to
e86e4f3
Compare
davecheney
commented
Dec 5, 2019
| @@ -1068,7 +1068,7 @@ func TestListenerVisit(t *testing.T) { | |||
|
|
|||
| func transportSocket(tlsMinProtoVersion envoy_api_v2_auth.TlsParameters_TlsProtocol, alpnprotos ...string) *envoy_api_v2_core.TransportSocket { | |||
| return envoy.DownstreamTLSTransportSocket( | |||
| envoy.DownstreamTLSContext("default/secret/28337303ac", tlsMinProtoVersion, alpnprotos...), | |||
| envoy.DownstreamTLSContext("default/secret/68621186db", tlsMinProtoVersion, alpnprotos...), | |||
There was a problem hiding this comment.
all the hashes changed because the name of a SDS entry contains the hash of its certificate. I'm not sure if this was a bright idea in retrospect.
jpeach
reviewed
Dec 5, 2019
jpeach
reviewed
Dec 5, 2019
Fixes projectcontour#1965 During cache insertion reject certificates which lack a Subject CommonName (CN) or SubjectAltName extension. This PR uncovered that, well basically, all our TLS fixtures don't fit this requirement which is extra sadface and thus this PR contains replacement fixtures for all the previous ones. This PR also adds a unit test for dag.isValidSecret as we are likely to continue to add to this function as further validation edge cases are uncovered. This necessitated a small addition to the internal/assert comparator logic to be able to compare error values. Signed-off-by: Dave Cheney <[email protected]>
davecheney
force-pushed
the
fixedbugs/1965
branch
from
e86e4f3 to
11d5179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1965
During cache insertion reject certificates which lack a Subject
CommonName (CN) or SubjectAltName extension.
This PR uncovered that, well basically, all our TLS fixtures don't fit
this requirement which is extra sadface and thus this PR contains
replacement fixtures for all the previous ones.
This PR also adds a unit test for dag.isValidSecret as we are likely to
continue to add to this function as further validation edge cases are
uncovered. This necessitated a small addition to the internal/assert
comparator logic to be able to compare error values.
Signed-off-by: Dave Cheney [email protected]