site: point to latest github release tag where possible #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
force-pushed
the
site-point-to-latest-release
branch
from
7d262e8 to
36e29c8
Compare
jpeach
suggested changes
Oct 24, 2019
| @@ -13,7 +13,7 @@ If you don't have a cluster with that capability see the [Running without a Kube | |||
| ### Recommended installation details | |||
|
|
|||
| The recommended installation of Contour is Contour running in a Deployment and Envoy in a Daemonset with TLS securing the gRPC communication between them. | |||
| The [`contour` example]({{site.github.repository_url}}/tree/master/examples/contour/README.md) will install this for you. | |||
| The [`contour` example]({{site.github.repository_url}}/blob/{{ site.github.latest_release.tag_name }}/examples/contour/README.md) will install this for you. | |||
There was a problem hiding this comment.
This resolves to https://github.com/projectcontour/contour/blob/v0.15.3/examples/contour/README.md which is 404.
|
@jpeach yup, all those links won't be valid today. This PR cannot land til 1.0 is cut. |
davecheney
added
the
priority/important-soon
davecheney
force-pushed
the
site-point-to-latest-release
branch
2 times, most recently
from
2767bce to
b83c2ff
Compare
Fixes projectcontour#1619 For 1.0 the plan of record is to keep the examples on GitHub. This is due to the difficulty in doing directory index style static resources from projectcontour.io. To support this weave the name of the current github release through the website. Note that at the present, in the rc.2 timeframe, this will break a lot of links so this PR is targeted for 1.0 (or shortly after) which will bring the guides, resources, and release documentation in line with the latest released tag on GitHub. Signed-off-by: Dave Cheney <[email protected]>
davecheney
force-pushed
the
site-point-to-latest-release
branch
from
b83c2ff to
5e430d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1619
For 1.0 the plan of record is to keep the examples on GitHub. This is
due to the difficulty in doing directory index style static resources
from projectcontour.io.
To support this weave the name of the current github release through the
website.
Note that at the present, in the rc.2 timeframe, this will break a lot
of links so this PR is targeted for 1.0 (or shortly after) which will
bring the guides, resources, and release documentation in line with the
latest released tag on GitHub.
Signed-off-by: Dave Cheney [email protected]