internal/dag: add logger to KubernetesCache #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
force-pushed
the
internal-dag-kubernetescache-add-logger
branch
from
d1bdd2e to
124b0c0
Compare
Updates projectcontour#513 Add a logger to the KubernetesCache. This is useful at the moment to spot failures to promulgate the projectcontour.HTTPLoadbalancer objects through Contour. This will also be useful to log cert validation failures, see projectcontour#513. Signed-off-by: Dave Cheney <[email protected]>
davecheney
force-pushed
the
internal-dag-kubernetescache-add-logger
branch
from
124b0c0 to
9ce7f4a
Compare
davecheney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #513
Add a logger to the KubernetesCache. This is useful at the moment to
spot failures to promulgate the projectcontour.HTTPLoadbalancer objects
through Contour.
This will also be useful to log cert validation failures, see #513.
Signed-off-by: Dave Cheney [email protected]