Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make updategenerated is broken after Go module changes #996

Closed
unicell opened this issue Apr 9, 2019 · 0 comments · Fixed by #1010
Closed

make updategenerated is broken after Go module changes #996

unicell opened this issue Apr 9, 2019 · 0 comments · Fixed by #1010
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
0.12.0

Comments

@unicell
Copy link
Contributor

unicell commented Apr 9, 2019

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

With a clean clone (no vendor folder), make updategenerated` fails because of

Updating CRD generated code...
hack/update-generated-crd-code.sh: line 22: hack/../vendor/k8s.io/code-generator/generate-groups.sh: No such file or directory
Makefile:95: recipe for target 'updategenerated' failed
make: *** [updategenerated] Error 127

What did you expect to happen:

make updategenerated passes without error

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Contour version:
  • Kubernetes version: (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
unicell added a commit to unicell/contour that referenced this issue Apr 9, 2019
@unicell
Dockerize CRD code generation to fix regression with Go modules
241557d 
Fixes projectcontour#996

Signed-off-by: Qiu Yu <[email protected]>
@unicell unicell mentioned this issue Apr 9, 2019
Closed
@davecheney davecheney added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 9, 2019
@davecheney davecheney assigned davecheney and unassigned davecheney Apr 9, 2019
@davecheney davecheney added this to the 0.12.0 milestone Apr 9, 2019
@davecheney davecheney removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Apr 10, 2019
@timh timh modified the milestone: 0.12.0 Apr 10, 2019
glerchundi added a commit to glerchundi/contour that referenced this issue Apr 10, 2019
@glerchundi
modules: pin dependencies and fix updategenerated
8c8d767 
Closes projectcontour#996

Signed-off-by: Gorka Lerchundi Osa <[email protected]>
@glerchundi glerchundi mentioned this issue Apr 10, 2019
Merged
glerchundi added a commit to glerchundi/contour that referenced this issue Apr 10, 2019
@glerchundi
modules: pin dependencies and fix updategenerated
f559483 
Closes projectcontour#996

Signed-off-by: Gorka Lerchundi Osa <[email protected]>
glerchundi added a commit to glerchundi/contour that referenced this issue Apr 10, 2019
@glerchundi
modules: pin dependencies and fix updategenerated
1b0ffb3 
Closes projectcontour#996

Signed-off-by: Gorka Lerchundi Osa <[email protected]>
glerchundi added a commit to glerchundi/contour that referenced this issue Apr 12, 2019
@glerchundi
modules: pin dependencies and fix updategenerated
f9cde7c 
Closes projectcontour#996

Signed-off-by: Gorka Lerchundi Osa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
0.12.0
3 participants
@davecheney @unicell @timh