Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from listener.useproxyprotocol to envoy.listener.proxy_protocol listener filter #802

Closed
davecheney opened this issue Nov 13, 2018 · 0 comments
Closed

Switch from listener.useproxyprotocol to envoy.listener.proxy_protocol listener filter #802

davecheney opened this issue Nov 13, 2018 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
0.10.0

Comments

@davecheney
Copy link
Contributor

Envoy supports a listener filter for proxy_protocol

https://www.envoyproxy.io/docs/envoy/latest/configuration/listener_filters/proxy_protocol

Perhaps that should be used instead of listener.filterchain.use_proxy_protocol.
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 13, 2018
@davecheney davecheney added this to the 0.9.0 milestone Nov 13, 2018
@davecheney davecheney mentioned this issue Dec 10, 2018
Closed
@davecheney davecheney modified the milestones: 0.9.0, 0.10.0 Jan 25, 2019
davecheney added a commit to davecheney/contour that referenced this issue Feb 5, 2019
@davecheney
internal/contour: use proxy_protocol PROXY listener
a8c621d 
Fixes projectcontour#802

The proxy_protocol listener filter supports PROXY V1 (AWS/ELB) and PROXY
V2 (HAProxy).

Signed-off-by: Dave Cheney <[email protected]>
@davecheney davecheney mentioned this issue Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@davecheney