Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or Update the Description printer column #2978

Open
stevesloka opened this issue Oct 2, 2020 · 3 comments
Open

Remove or Update the Description printer column #2978

stevesloka opened this issue Oct 2, 2020 · 3 comments
Labels
area/httpproxy Issues or PRs related to the HTTPProxy API. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@stevesloka
Copy link
Member

Since merging #2962 we don't need the Description field in the printer columns since now it's either "valid" or "invalid". The description is redundant and doesn't offer any more information and we can remove the description.

image
stevesloka added a commit to stevesloka/contour that referenced this issue Oct 5, 2020
@stevesloka
internal/k8s: Ignore LastTransitionTime for HTTPProxy objects status …
98ba0f8 
…equal check

Change how the comparison of the status of the object of HTTPProxy objects by
ignoring the LastTransitionTime which is always updates on each DAG rebuild
regardless if the status of object changed or not.

Not ignoring this causes each status to be updated each time since the objects
are always different for each DAG rebuild.

Fixes projectcontour#2978

Signed-off-by: Steve Sloka <[email protected]>
@stevesloka stevesloka mentioned this issue Oct 5, 2020
Merged
@skriss
Copy link
Member

skriss commented Oct 5, 2020 •
edited
Loading

This makes me wonder -- do we need to carry the .status.currentStatus field indefinitely to be able to show something useful about the validity of the proxy in kubectl get output, now that we're using conditions? Or is there a way to index into the conditions to actually show the state of the Valid condition?

Looks like the answer is JSONPath.

@jpeach
Copy link
Contributor

jpeach commented Oct 6, 2020

This makes me wonder -- do we need to carry the .status.currentStatus field indefinitely to be able to show something useful about the validity of the proxy in kubectl get output, now that we're using conditions?

We can't remove the field from the V1 API because it would be an incompatible change.

Or is there a way to index into the conditions to actually show the state of the Valid condition?

Looks like the answer is JSONPath.

Yup; pretty sure that we could show all the errors in a printer column. We do need to rethink these for DetailedCondition.

@youngnick youngnick added area/httpproxy Issues or PRs related to the HTTPProxy API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Oct 22, 2020
@jpeach jpeach changed the title Remove Description printer column Remove or Update the Description printer column Nov 18, 2020
@youngnick youngnick added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Nov 18, 2020
@kushthedude kushthedude mentioned this issue Mar 28, 2021
Closed
@youngnick
Copy link
Member

Seems like the consensus on #3523 was that we should update the Description column to summarize the Conditions somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/httpproxy Issues or PRs related to the HTTPProxy API. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove description column of httpproxy kushthedude/contour
4 participants
@jpeach @stevesloka @skriss @youngnick