Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/dag: GetProxyStatusesTesting function should be removed #2967

Closed
youngnick opened this issue Oct 1, 2020 · 0 comments · Fixed by #3243
Closed

internal/dag: GetProxyStatusesTesting function should be removed #2967

youngnick opened this issue Oct 1, 2020 · 0 comments · Fixed by #3243
Labels
area/testing Issues or PRs related to tests or testing tools. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@youngnick
Copy link
Member

The GetProxyStatusesTesting function in internal/dag/dag.go is used for the tests in internal/dag/status_test.go. It currently takes the values stored in the status.Cache and mutates them into a format that's easier to consume.

To remove it, we'll need to:

  • Figure out a way to interact with the cache that allows you to get the conditions for a named object of type HTTPProxy. @jpeach suggested that maybe we may change the cache to have a Walk style method, but this is up for grabs.
  • Change all 61 test cases to use this new method.
@youngnick youngnick added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/testing Issues or PRs related to tests or testing tools. labels Oct 1, 2020
@youngnick youngnick mentioned this issue Oct 1, 2020
Merged
stevesloka added a commit to stevesloka/contour that referenced this issue Jan 8, 2021
@stevesloka
internal/dag: Remove GetProxyStatusesTesting function
bb5a69b 
The GetProxyStatusesTesting() was left in the dag package to allow for an easy way to mutate
values stored in the status.Cache into an easier format to consume. This removes the helper
function, leaving the work to implement a different pattern to projectcontour#2969.

Fixes projectcontour#2967

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jan 8, 2021
@stevesloka
internal/dag: Remove GetProxyStatusesTesting function
1b4b808 
The GetProxyStatusesTesting() was left in the dag package to allow for an easy way to mutate
values stored in the status.Cache into an easier format to consume. This removes the helper
function, leaving the work to implement a different pattern to projectcontour#2969.

Fixes projectcontour#2967

Signed-off-by: Steve Sloka <[email protected]>
@stevesloka stevesloka mentioned this issue Jan 8, 2021
Merged
stevesloka added a commit that referenced this issue Jan 11, 2021
@stevesloka
internal/dag: Remove GetProxyStatusesTesting function (#3243)
980de61 
The GetProxyStatusesTesting() was left in the dag package to allow for an easy way to mutate
values stored in the status.Cache into an easier format to consume. This removes the helper
function, leaving the work to implement a different pattern to #2969.

Fixes #2967

Signed-off-by: Steve Sloka <[email protected]>
erwbgy pushed a commit to erwbgy/contour that referenced this issue Jan 14, 2021
@stevesloka @erwbgy
internal/dag: Remove GetProxyStatusesTesting function (projectcontour…
b4bc2ad 
…#3243)

The GetProxyStatusesTesting() was left in the dag package to allow for an easy way to mutate
values stored in the status.Cache into an easier format to consume. This removes the helper
function, leaving the work to implement a different pattern to projectcontour#2969.

Fixes projectcontour#2967

Signed-off-by: Steve Sloka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to tests or testing tools. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

internal/dag: Remove GetProxyStatusesTesting function stevesloka/contour
1 participant
@youngnick