Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minikube example link broken #133

Closed
stevesloka opened this issue Jan 5, 2018 · 2 comments
Closed

Minikube example link broken #133

stevesloka opened this issue Jan 5, 2018 · 2 comments
Assignees
@rbankston
Milestone
0.3.0

Comments

@stevesloka
Copy link
Member

The minikube example link (https://github.com/heptio/contour#configuring-dns) does not work.

Currently: https://j.hept.io/contour-kuard-minikube-example maps to: https://github.com/heptio/contour/raw/minikube/deployment/example-workload/kuard-minikube.yaml which is invalid.
@davecheney
Copy link
Contributor

@rbankston this was #16. Can you please fix the shortlink or send a PR to revert this change. Thank you.

@davecheney davecheney added this to the 0.3.0 milestone Jan 9, 2018
@rbankston
Copy link
Contributor

The shortlink has been fixed and works as expected. @davecheney @stevesloka

sunjayBhatia pushed a commit that referenced this issue Jan 30, 2023
@danehans
Adds e2e Testing (#133)
f341fae 
Signed-off-by: Daneyon Hansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbankston rbankston

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
3 participants
@davecheney @rbankston @stevesloka