Skip to content

Commit

Permalink
Small comment update
Browse files Browse the repository at this point in the history
Signed-off-by: Nick Young <[email protected]>
  • Loading branch information
Nick Young committed Oct 2, 2020
1 parent 81c4824 commit e3468bc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion internal/dag/httpproxy_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ func (p *HTTPProxyProcessor) computeHTTPProxy(proxy *contour_api_v1.HTTPProxy) {
}
pa.Vhost = host

// ensure root httpproxy lives in allowed namespace
// Ensure root httpproxy lives in allowed namespace.
// This check must be after we can determine the vhost in order to be able to calculate metrics correctly.
if !p.rootAllowed(proxy.Namespace) {
validCond.AddError("RootNamespaceError", "RootProxyNotAllowedInNamespace",
"root HTTPProxy cannot be defined in this namespace")
Expand Down

0 comments on commit e3468bc

Please sign in to comment.