Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Fix codespell: Stop correction of complies->compiles #533

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia requested a review from a team as a code owner August 17, 2022 23:44
@sunjayBhatia sunjayBhatia requested review from tsaarni and stevesloka and removed request for a team August 17, 2022 23:44
@sunjayBhatia
Copy link
Member Author

Another option is to stop using the rare words/corrections dictionary which is enabled by default and contains the complies->compiles correction

@sunjayBhatia
Copy link
Member Author

will probably need to make a similar change in contour as well

@sunjayBhatia sunjayBhatia requested a review from skriss August 17, 2022 23:47
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #533 (c2b4e9b) into main (537e5cf) will decrease coverage by 2.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   80.46%   77.66%   -2.81%     
==========================================
  Files          29       29              
  Lines        2171     2171              
==========================================
- Hits         1747     1686      -61     
- Misses        305      346      +41     
- Partials      119      139      +20     
Impacted Files Coverage Δ
internal/objects/contour/finalizer.go 62.50% <0.00%> (-18.75%) ⬇️
internal/controller/controller.go 72.13% <0.00%> (-10.66%) ⬇️
internal/status/status.go 64.86% <0.00%> (-8.11%) ⬇️
internal/objects/configmap/configmap.go 70.88% <0.00%> (-6.33%) ⬇️
internal/objects/service/service.go 83.92% <0.00%> (-5.36%) ⬇️
internal/objects/contour/contour.go 76.62% <0.00%> (-5.20%) ⬇️
internal/objects/job/job.go 77.50% <0.00%> (-5.00%) ⬇️
internal/objects/rbac.go 56.47% <0.00%> (-3.53%) ⬇️
internal/objects/daemonset/daemonset.go 93.21% <0.00%> (-2.50%) ⬇️
internal/objects/deployment/deployment.go 91.98% <0.00%> (-2.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tsaarni tsaarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd assume it is better to add to ignore than to drop rare dictionary altogether. Corrections there look useful, except "complies".

@skriss skriss merged commit f26d6ea into projectcontour:main Aug 18, 2022
@sunjayBhatia sunjayBhatia deleted the fix-codespell branch August 22, 2022 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants