Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common gRPC server code. #9

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Sep 30, 2020

Move the common gRPC server initialization code into a helper function.

Signed-off-by: James Peach [email protected]

Move the common gRPC server initialization code into a helper function.

Signed-off-by: James Peach <[email protected]>
@jpeach jpeach requested a review from youngnick September 30, 2020 05:18
Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpeach jpeach merged commit 71f16eb into projectcontour:main Sep 30, 2020
@jpeach jpeach deleted the default-grpc-server branch September 30, 2020 05:33
robinfoe pushed a commit to robinfoe/contour-authserver that referenced this pull request Feb 11, 2021
Move the common gRPC server initialization code into a helper function.

Signed-off-by: James Peach <[email protected]>
Signed-off-by: robinfoe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants