Fix MediaSDK_C2 Coverity issues #88
Open
+87
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kexiaox
force-pushed
the
FixCoverityIssues
branch
5 times, most recently
from
66c18e5
to
23f1d29
Compare
zhangyichix
reviewed
Mar 29, 2023
c2_utils/src/mfx_cmd_queue.cpp
Outdated
| } | ||
| catch(const std::exception& e) | ||
| { | ||
| std::cerr << e.what() << '\n'; |
There was a problem hiding this comment.
std::cerr doesn't work on android, pls instead of ALOGE
zhangyichix
reviewed
Mar 29, 2023
zhangyichix
reviewed
Mar 29, 2023
zhangyichix
reviewed
Mar 29, 2023
c2_utils/include/mfx_pool.h
Outdated
| } | ||
| catch(const std::exception& e) | ||
| { | ||
| std::cerr << e.what() << '\n'; |
There was a problem hiding this comment.
std::cerr doesn't work on android, pls instead of ALOGE
zhangyichix
reviewed
Mar 29, 2023
zhangyichix
reviewed
Mar 29, 2023
c2_utils/include/mfx_cmd_queue.h
Outdated
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| #include <C2Work.h> | |||
|
|
|||
| #include <iostream> | |||
There was a problem hiding this comment.
if using ALOGE instead of std::cerr, consider removing it.
zhangyichix
reviewed
Mar 29, 2023
c2_utils/src/mfx_c2_utils.cpp
Outdated
| @@ -669,7 +669,7 @@ YUVWriter::YUVWriter(const std::string& dir, | |||
|
|
|||
| if (!dir_exists) { | |||
| MFX_DEBUG_TRACE_STREAM(NAMED(full_name.str())); | |||
| mkdir(full_name.str().c_str(), S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH); | |||
| mkdir(full_name.str().c_str(), S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH); //TODO Uncheck return vaule | |||
There was a problem hiding this comment.
if(mkdir(full_name.str().c_str(), S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH)) {
MFX_DEBUG_TRACE_MSG("cannot create the path");
return;
}
If it returns 0 on success
zhangyichix
suggested changes
Mar 29, 2023
Kexiaox
force-pushed
the
FixCoverityIssues
branch
3 times, most recently
from
fab75e1
to
3468bc5
Compare
zhangyichix
approved these changes
Mar 29, 2023
dyang23
approved these changes
Mar 29, 2023
TianmiChen
approved these changes
Mar 30, 2023
issues summary: Uncheck return vaule; self assign; pass nullpointer; Tracked-On: OAM-108581 Signed-off-by: Ke Xiao <[email protected]> Signed-off-by: Zhnang Yichi <[email protected]>
Kexiaox
force-pushed
the
FixCoverityIssues
branch
from
3468bc5
to
f8df2b6
Compare
|
Hi @dyang23 @TianmiChen @zhangyichix I have updated PR, please help review |
TianmiChen
approved these changes
Mar 30, 2023
dyang23
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues summary: Uncheck return; self assign; pass nullpointer;