Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dGPU for decoder and encoder #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shao-Feng
Copy link
Contributor

1\ Enable ONEVPL_EXPERIMENTAL for init dGPU session and get deviceId
2\ According to device id to judge if it is dGPU or iGPU
3\ dGPU deviceid range: 0x5600 < deviceId < 0x56B3
4\ After initializing dGPU, reset RateControl for dGPU.
5\ Set buffer Tile4 for dGPU and Y-Tile for iGPU

@Shao-Feng
Copy link
Contributor Author

@YuanjunHuang @dyang23 @TianmiChen @zhangyichix
Please help to review

c2_components/src/mfx_c2_encoder_component.cpp Outdated Show resolved Hide resolved
c2_components/include/mfx_c2_component.h Outdated Show resolved Hide resolved
c2_components/Android.mk Outdated Show resolved Hide resolved
@Shao-Feng Shao-Feng force-pushed the dGPU_enabling branch 3 times, most recently from 4edac69 to 61d2493 Compare September 5, 2023 03:15
@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@@ -84,6 +84,9 @@ class MfxC2Component : public C2ComponentInterface,

public:
virtual ~MfxC2Component();
#ifdef ONEVPL_EXPERIMENTAL
bool isdGPU() { return dedicated;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the device detection logic to mfx_dev.cpp/mfx_dev_va.cpp, please.

Thanks,
Tianmi

@@ -174,6 +177,13 @@ class MfxC2Component : public C2ComponentInterface,

std::unique_lock<std::mutex> AcquireRunningStateLock(bool may_block) const;

#ifdef ONEVPL_EXPERIMENTAL
void detectdGPU(mfxU16 deviceId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the device detection logic to mfx_dev.cpp/mfx_dev_va.cpp, please.

Thanks,
Tianmi

c2_components/include/mfx_c2_component.h Outdated Show resolved Hide resolved
c2_components/include/mfx_c2_component.h Outdated Show resolved Hide resolved
c2_utils/src/mfx_dev_va.cpp Show resolved Hide resolved
c2_utils/src/mfx_dev_va.cpp Show resolved Hide resolved
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

2 similar comments
@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

1\ Enable ONEVPL_EXPERIMENTAL for init dGPU session and get deviceId
2\ According to device id to judge if it is dGPU or iGPU
3\ dGPU deviceid range: 0x5600 < deviceId < 0x56B3
4\ After initializing dGPU, reset RateControl for dGPU.
5\ Set buffer Tile4 for dGPU and Y-Tile for iGPU

Signed-off-by: Shaofeng Tang <[email protected]>
@sysopenci sysopenci added the Stale Stale label for inactive open prs label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid commit message Stale Stale label for inactive open prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants