Remove cros_gralloc include directory #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TianmiChen
approved these changes
Jun 14, 2023
Tracked-On: OAM-110710 Signed-off-by: Jeevaka Prabu Badrappan <[email protected]>
JeevakaPrabu
force-pushed
the
minigbm_include_path_removal
branch
from
19d827c
to
7aa8aea
Compare
sysopenci
added
Valid commit message
and removed
Valid commit message
PR approved
labels
TianmiChen
reviewed
Jun 14, 2023
| @@ -33,7 +33,7 @@ mfx_cc_defaults { | |||
| export_include_dirs: ["include"], | |||
|
|
|||
| include_dirs: [ | |||
| "hardware/intel/external/minigbm-intel/cros_gralloc", // remove then minigbm gets Android.bp | |||
| "hardware/intel/external/minigbm/cros_gralloc", // remove then minigbm gets Android.bp | |||
There was a problem hiding this comment.
Looks we don't have this folder hardware/intel/external/minigbm/cros_gralloc in celadon. What we have is hardware/intel/external/minigbm-intel.
sysopenci
added
Valid commit message
and removed
Valid commit message
PR approved
labels
|
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details |
|
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing hardcoded cros_gralloc include directory as it is already added in mfx_c2_defs.mk
Tracked-On: OAM-110710