chore: drop related name on base model created_by_user
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused, for example, on the `User` model to set an `acl` attribute, pointing to the creator. This is very confusing, for example if searching for all users within a scope: >>> User.objects.filter(acl__scope__in=scope_list) This would return the user who has *created* all those ACLs, instead of the users who are in fact *granted* the ACL. The correct way would have been >>> User.objects.filter(acls__scope__in=scope_list) So to avoid this confusion (and others), we'll remove the related name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused, for example, on the
Usermodel to set anaclattribute, pointing to the creator.This is very confusing, for example if searching for all users within a scope:
This would return the user who has created all those ACLs, instead of the users who are in fact granted the ACL.
The correct way would have been
So to avoid this confusion (and others), we'll remove the related name.