Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scopes): expose level on api #253

Merged
merged 1 commit into from
Jul 30, 2021
Merged

feat(scopes): expose level on api #253

merged 1 commit into from
Jul 30, 2021

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Jul 29, 2021

read_only_fields didn't work, but I added a test that shows that level can't be written to anyway.

@czosel czosel requested a review from winged July 29, 2021 14:05
winged
winged approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@winged
Copy link
Contributor

winged commented Jul 29, 2021

Seems to need a pytest --snapshot-update

@czosel
Copy link
Contributor Author

czosel commented Jul 29, 2021

done!

@winged winged merged commit 73a4965 into master Jul 30, 2021
@czosel czosel mentioned this pull request Jul 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged winged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czosel @winged