Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and remove deprecation #151

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Add tests and remove deprecation #151

merged 2 commits into from
Jan 27, 2023

Conversation

velrest
Copy link
Contributor

@velrest velrest commented Jan 18, 2023

BREAKING CHANGE:

  • Remove previously deprecated getUnlocalizedField.
  • Access the localized object of an attribute via localizedObjects.myField instead of the magic key myFieldObject.

Depends on #150

@velrest velrest self-assigned this Jan 18, 2023
@velrest velrest requested review from Yelinz, anehx and czosel January 18, 2023 15:34
@velrest velrest mentioned this pull request Jan 19, 2023
@velrest velrest force-pushed the tests branch 3 times, most recently from a9111a3 to 21fc6c7 Compare January 26, 2023 11:42
@velrest velrest requested a review from derrabauke January 26, 2023 14:57
@velrest velrest force-pushed the tests branch 2 times, most recently from a667c00 to 30d20db Compare January 26, 2023 15:06
… object of a field

BREAKING CHANGE:
- Remove previously deprecated `getUnlocalizedField`.
- Access the localized object of an attribute via `localizedObjects.myField` instead of the magic key `myFieldObject`.
Copy link

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨 solid!

@velrest velrest force-pushed the tests branch 2 times, most recently from 6e2438e to 80eadb0 Compare January 27, 2023 09:17
@velrest
Copy link
Contributor Author

velrest commented Jan 27, 2023

Embroider tests disabled for now due to emberjs/data#8396

@velrest velrest merged commit 87fb686 into projectcaluma:main Jan 27, 2023
@czosel
Copy link
Contributor

czosel commented Jan 27, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants