Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-table): always include page query param #544

Merged
merged 1 commit into from
Aug 8, 2022
Merged

fix(data-table): always include page query param #544

merged 1 commit into from
Aug 8, 2022

Conversation

derrabauke
Copy link
Contributor

The page query param was missing and therefore no meta info was included in the response from the server, leading to a blank pagination status and a broken search behavior.

Reverts changes from #302

winged
winged approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derrabauke derrabauke merged commit 43c6a28 into projectcaluma:main Aug 8, 2022
github-actions bot pushed a commit that referenced this pull request Aug 8, 2022
@semantic-release-bot
chore(release): 6.2.1 [skip ci]
435c589 
## [6.2.1](v6.2.0...v6.2.1) (2022-08-08)

### Bug Fixes

* **data-table:** always include page meta info ([#544](#544)) ([43c6a28](43c6a28))
* **editForm:** relax phone regex ([#537](#537)) ([bd2d63c](bd2d63c))
* phone number placeholder ([#538](#538)) ([9b75903](9b75903))
@czosel
Copy link
Contributor

czosel commented Aug 8, 2022

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@czosel czosel added the released label Aug 8, 2022
@velrest velrest mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged winged approved these changes

@czosel czosel Awaiting requested review from czosel

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabauke @czosel @winged