Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emeis-options): add setting to force the locale of models #419

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Feb 17, 2022

This makes the already existing override for field locales configurable
via the emeis-options service. The existing override on model level has
been removed, because it's not accessible when ember-emeis is used as an
engine.

The override is useful for cases when translations for specific models
are not required / wanted.

This makes the already existing override for field locales configurable
via the emeis-options service. The existing override on model level has
been removed, because it's not accessible when ember-emeis is used as an
engine.

The override is useful for cases when translations for specific models
are not required / wanted.
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -6,12 +6,12 @@
@updateModel={{this.updateModel}}
@listViewRouteName="scopes.index"
>
<EditForm::Element @label={{t "emeis.scopes.headings.name"}}>
<EditForm::Element @label={{t "emeis.scopes.headings.fullName"}}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by fix

@winged winged merged commit 95908b0 into projectcaluma:main Feb 17, 2022
@czosel
Copy link
Contributor Author

czosel commented Feb 17, 2022

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants