Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: rename meta attribute to metainfo (django-rf change) #404

Merged

Conversation

derrabauke
Copy link
Contributor

Since django rest framework made this key a reserved attribute, we have to rename it for our usage.
More info see here

This change requires the emeis backend version >= 1.0.0

!BREAKING CHANGE

Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derrabauke derrabauke changed the title fix: rename meta attribute to metainfo (django-rf change) fix!: rename meta attribute to metainfo (django-rf change) Feb 4, 2022
@derrabauke derrabauke force-pushed the fix-meta-to-metainfo-basemodel-key branch from 5d9c9b3 to 08e65e4 Compare February 4, 2022 15:46
@derrabauke derrabauke merged commit 253d160 into projectcaluma:main Feb 4, 2022
@derrabauke derrabauke deleted the fix-meta-to-metainfo-basemodel-key branch February 4, 2022 15:47
@czosel
Copy link
Contributor

czosel commented Feb 4, 2022

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants